(fix) O3-4004: Fix Patient action menu button workspace #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns (#1294) This PR refactors the registration form's cancel modal to match new modal naming and registration conventions. Modals are now registered in the routes registry file under the `modals`. The naming convention has also changed - modals now use the `*.modal.tsx` suffix. I've also amended the modal to use Carbon's ModalBody, ModalHeader, and ModalFooter components instead of using divs with custom classes. Finally, I've amended the modal title and content to align with other confirmation modals in O3.
kb019
changed the title
chibongho
reviewed
Oct 7, 2024
| import { launchWorkspace } from '@openmrs/esm-framework'; | ||
| import { type WardPatient, type WardPatientWorkspaceProps } from '../types'; | ||
|
|
||
| let wardPatient: WardPatient = null; |
There was a problem hiding this comment.
Can you add a comment on why we need this?
There was a problem hiding this comment.
added the comment.Thanks
chibongho
approved these changes
Oct 7, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
The Patient action menu button does not work when other action menus are clicked and again when we click back the patient action button. Hopefully this pr fixed it.
Screenshots
OpenMRS.and.4.more.pages.-.Personal.-.Microsoft_.Edge.2024-10-06.19-51-33.webm
Related Issue
https://openmrs.atlassian.net/browse/O3-4004